Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adns: 1.5.1 -> 1.6.0 #92656

Merged
merged 1 commit into from Jul 8, 2020
Merged

adns: 1.5.1 -> 1.6.0 #92656

merged 1 commit into from Jul 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

saw it needed updating in logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from peti July 7, 2020 22:38
@jonringer jonringer force-pushed the bump-adns branch 2 times, most recently from 36ce06f to 1d39a1f Compare July 7, 2020 23:35
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build adns

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build adns

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build adns

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build adns

@jonringer
Copy link
Contributor Author

if someone wants to fix the darwin installation, they can. The executables seem to be defunct, but the library should be linkable

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build adns

@peti peti merged commit b97abb9 into NixOS:master Jul 8, 2020
@jonringer jonringer deleted the bump-adns branch July 8, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @peti