Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gscan2pdf: add scanimage to PATH in wrapper #92619

Merged
merged 1 commit into from Jul 8, 2020
Merged

gscan2pdf: add scanimage to PATH in wrapper #92619

merged 1 commit into from Jul 8, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jul 7, 2020

Motivation for this change

As suggested by @danieldk in #92471 (review)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
gscan2pdf: add scanimage to PATH in wrapper
bf40153 
Gscan2pdf/Frontend/CLI.pm calls this binary.
danieldk
danieldk approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this change. I usually review applications by running them in a bubblewrap. Since this doesn't expose environment variables and reveals only part of the filesystem, it helps finding implicit dependencies. With this change gscan2pdf runs without errors in the sandbox as well 🎉

Result of nixpkgs-review pr 92619 1

1 package built:
- gscan2pdf

@danieldk danieldk merged commit b31ec45 into NixOS:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @danieldk