Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better helical triangulation #489 and #550 fixed. #643

Merged
merged 1 commit into from Jul 11, 2020
Merged

Better helical triangulation #489 and #550 fixed. #643

merged 1 commit into from Jul 11, 2020

Conversation

phkahler
Copy link
Member

@phkahler phkahler commented Jul 7, 2020

…4 segments and forcing grid triangulation to use a minimum of 4x4 quads. This helps with issue #489. Also add a max_dt parameter for PWL creation and use that for helical edges.

@phkahler
Copy link
Member Author

phkahler commented Jul 8, 2020

I want to hold off on this a bit more. Sorry for going too fast.

@whitequark
Copy link
Contributor

Take all the time you need! There's no harm in having half-done pull requests (it may even help a bit by showing who works on what, and perhaps inspiring collaboration).

@phkahler phkahler mentioned this pull request Jul 8, 2020
Closed
@phkahler
Better helical triangulation - issue 489.
74cd752 
Resolve issue solvespace#489 helix has stairsteps.
Force helix axis line to 8 segments.
Grid triangulation to use a minimum of 4 segments for degree>1.
Adds twist dependence for grid triangulation with degree=1.
Added a max_dt parameter for PWL creation and use that for helical edges.
@phkahler phkahler mentioned this pull request Jul 9, 2020
Closed
@phkahler
Copy link
Member Author

phkahler commented Jul 9, 2020

@whitequark this seems to fix #550 as well. If you're OK with it I am.

@phkahler phkahler changed the title Better helical triangulation by forcing twisted curves to minimum of … Better helical triangulation - issue 489. Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation - issue 489. Better helical triangulation Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation Better helical triangulation Resolve issue #489 helix has stairsteps. Force helix axis line to 8 segments. Grid triangulation to use a minimum of 4 segments for degree>1. Adds twist dependence for grid triangulation with degree=1. Added a max_dt parameter for PWL creation and use that for helical edges. Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation Resolve issue #489 helix has stairsteps. Force helix axis line to 8 segments. Grid triangulation to use a minimum of 4 segments for degree>1. Adds twist dependence for grid triangulation with degree=1. Added a max_dt parameter for PWL creation and use that for helical edges. Better helical triangulation #489 and #550 fixed. Jul 10, 2020
This was linked to issues Jul 11, 2020
Helix difference extrusion yeilds staircase effect #489
Closed
Helix tool almost always results in invalid mesh #550
Closed
@phkahler phkahler merged commit 9802b5d into solvespace:master Jul 11, 2020
@phkahler phkahler deleted the better_helix branch July 18, 2020 16:11
@ruevs ruevs mentioned this pull request Oct 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helix tool almost always results in invalid mesh Helix difference extrusion yeilds staircase effect
2 participants
@phkahler @whitequark