Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tmp file from tarball job #93161

Merged
merged 1 commit into from Jul 15, 2020
Merged

Remove tmp file from tarball job #93161

merged 1 commit into from Jul 15, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jul 15, 2020

Brought up in
https://discourse.nixos.org/t/what-is-the-100mib-text-file-tmp-in-recent-channels-nixexprs-tar-xz/8137
and introduced by
d6ec410.

Motivation for this change

https://discourse.nixos.org/t/what-is-the-100mib-text-file-tmp-in-recent-channels-nixexprs-tar-xz/8137

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-is-the-100mib-text-file-tmp-in-recent-channels-nixexprs-tar-xz/8137/4

chkno
chkno approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@chkno chkno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. Thanks for fixing this.

(Another option would be to not generate a tmp file in the first place)

@grahamc grahamc merged commit ff42f46 into NixOS:master Jul 15, 2020
@cole-h cole-h deleted the rm-tmp branch July 15, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkno chkno chkno approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cole-h @nixos-discourse @chkno @grahamc