Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structurizr-cli: init at 1.3.1 #93188

Closed
wants to merge 1 commit into from
Closed

structurizr-cli: init at 1.3.1 #93188

wants to merge 1 commit into from

Conversation

bbcmgdm
Copy link

@bbcmgdm bbcmgdm commented Jul 15, 2020

Motivation for this change

Add {{structurizr-cli}}

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbcmgdm bbcmgdm marked this pull request as draft July 15, 2020 15:19
@bbcmgdm bbcmgdm closed this Jul 15, 2020
arjunv27
arjunv27 reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@arjunv27 arjunv27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunv27 arjunv27 arjunv27 left review comments

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbcmgdm @arjunv27 @Janik-Haag @mgdm