Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/slock: make the package configurable #93163

Closed
wants to merge 1 commit into from
Closed

nixos/slock: make the package configurable #93163

wants to merge 1 commit into from

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 15, 2020

Motivation for this change

I would like to make slock package configurable.

Add package option, so we can do this:

programs.slock = {
   enable = true;
   package = pkgs.overlay.slock; # use my customized slock package
};
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 15, 2020

Hi, @marsam, I think this PR is ready to be merged. Thank you very much!!

@aanderse
Copy link
Member

If you replaced slock with an overlay your system should already be using the custom version...

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 15, 2020

@aanderse, Thanks for the review!!
Yes, I have my customized slock, but I would like to add package option.
If we have package option, we would not need to add another config module overlay like nixos/modules/program/slock.nix.

@xrelkd xrelkd closed this Jul 17, 2020
@xrelkd xrelkd deleted the select-slock-pkg branch July 17, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @aanderse