New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm{8,11}-ce: init at 20.1.0 #93139
Conversation
Not a bad idea. Tough I have graalvm core working in my PR, holding back because I still don't have the graalpython/graal-js and other polyglots working yet. Can you confirm if the polyglot binaries work? If so this will be a good interim solution. One of my biggest problem in my PR is lack of response and comments from maintainers. I think I will continue on my PR next month using newer version, many of the problems I was hitting have been resolved in newer releases after I reported them upstream. Alternatively we can say, screw the polyglots and let's get the core working properly, hence why I'm trying to make the libraries independent from the rest (perhaps an overly-abitious pursuit). |
@hlolli the wasm binary doesn't crash, but I'm unable to confirm that it runs any wasm file. |
@bennyandresen thanks for working on this, I like the idea. In fact, I was thinking on opening a similar PR myself, but I didn't find time to work on it. I'll try it tomorrow |
same here I'll give this PR a try tomorrow. The fact that the polyglots langs are working is a seller to me. |
I'm missing some assets from the release page: I can't find the python nor the ruby jars: |
@GrahamcOfBorg build graalvm11-ce |
c846470
to
37d697b
Compare
@jlesquembre I already had them downloaded and therefor didn't realize that only wasm is included in the core graalvm release. graalpython and truffleruby are their own projects but are vm-compatible on their own release page. Fixed in the commit I just updated. |
@GrahamcOfBorg build graalvm11-ce |
@bennyandresen thanks, looks better now, I was able to build it locally, still need to test the executables |
@GrahamcOfBorg build graalvm8-ce |
I was able to compile a clojure project, looks good to me |
I found an error:
|
37d697b
to
1b8c6cb
Compare
thanks! fixed in latest push. |
Hello, I don't know if you can add support for Darwin. I did a quick search and found that GHC supports Darwin using dynamic libraries (https://github.com/NixOS/nixpkgs/blob/dbb7aaef62bb6e7cece233111914879c46d593fa/pkgs/development/compilers/ghc/8.6.5-binary.nix) |
1b8c6cb
to
2674ca1
Compare
I tried for 30 minutes to integrate both platforms into a single file, but I wasn't successful. |
2674ca1
to
3c3eb69
Compare
I was using I'd like to get this merged and update |
@bennyandresen can you please update your maintainer references so the build completes/this PR can get merged? I'm eager to use this and use the resulting binary cached derivation. |
What's missing here to make this buildable? Do we need to rerun the tests? It looks like the error listed in the failing check has been resolved. |
Something I noticed using this: If I try to compile a static native-image (with the "--static" flag), I get some weird errors with Clojure related to using the clj-http-lite library trying to make simple http requests. The executable will run fine from the computer I compiled it on, but if I run it from a different one, it fails. I can compile it dynamically but then it's guaranteed to not work pretty much anywhere else because of how the paths are in nix. The same exact code works fine anywhere (or at least on Debian, Ubuntu, and NixOS) if I compile it on Ubuntu by installing the latest version of graalvm-ce using the instructions in the docs. I'm guessing this would have something to do with how the static zlib and glibc stuff is being handled in the nix derivation but I don't know anywhere near enough about graalvm or java to say for sure.
|
if @bennyandresen is busy and it feels kosher to people I'd love to take this and rebase it to fix the eval error |
Please go ahead. If there is a way for me to transfer this PR over to you, I'll do that. |
I'll just open a new one. thanks 😄 |
Done, along with a version bump. This can safely be closed now. |
Closing in favor of #99631 |
Motivation for this change
babashka requires graalvm20 and building graalvm20 from source seems rather difficult and the extremely long compile times and other issues that @hlolli is experiencing are rather draining.
For now I would propose that we add graalvm8-ce and graalvm11-ce
I will add a PR to babashka and clj-kondo that make them depend on graalvm11-ce until we have a better graalvm "built from source" story.
for more information see #83080
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc: @volth @jlesquembre