Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 83.0.4103.116 -> 84.0.4147.89 #93149

Merged
merged 1 commit into from Jul 15, 2020
Merged

chromium: 83.0.4103.116 -> 84.0.4147.89 #93149

merged 1 commit into from Jul 15, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jul 14, 2020 •
edited

https://chromereleases.googleblog.com/2020/07/stable-channel-update-for-desktop.html

This update includes 38 security fixes.

CVEs:
CVE-2020-6510 CVE-2020-6511 CVE-2020-6512 CVE-2020-6513 CVE-2020-6514
CVE-2020-6515 CVE-2020-6516 CVE-2020-6517 CVE-2020-6518 CVE-2020-6519
CVE-2020-6520 CVE-2020-6521 CVE-2020-6522 CVE-2020-6523 CVE-2020-6524
CVE-2020-6525 CVE-2020-6526 CVE-2020-6527 CVE-2020-6528 CVE-2020-6529
CVE-2020-6530 CVE-2020-6531 CVE-2020-6533 CVE-2020-6534 CVE-2020-6535
CVE-2020-6536

Testing status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium ✔️ @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash

Let's hope the M84 build didn't break again since my last test and the browser still works at runtime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Jul 14, 2020

Sorry, I opened the PR a bit to early (I always ensure that at least everything before the build phase works). Unfortunately enable-vdpau-support-for-nvidia.patch originally contained an old workaround that broke in the meantime. I updated the patch and everything up to the configuration phase works now.

danielfullmer
danielfullmer approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and briefly tested chromium and nixosTests.chromium on x86_64-linux. Tested youtube, twitch, and as well as WebGL. They all seem to be working fine for me.

@thefloweringash
Copy link
Member

thefloweringash commented Jul 15, 2020 •
edited

Built chromium and nix-build nixos/tests/chromium.nix -A stable successfully on aarch64-linux but did not test interactively. LGTM.

@primeos
Copy link
Member Author

primeos commented Jul 15, 2020

Awesome :) I'm relieved to hear that it does still work as the M84 build already broke twice and was a bit annoying to fix IIRC.
Thanks for testing! ❤️

@primeos primeos merged commit 2ec04dc into NixOS:master Jul 15, 2020
@primeos primeos mentioned this pull request Jul 15, 2020
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @thefloweringash @danielfullmer @TredwellGit