Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cli: 2.8.0 -> 2.9.0 #93151

Merged
merged 1 commit into from Jul 17, 2020
Merged

azure-cli: 2.8.0 -> 2.9.0 #93151

merged 1 commit into from Jul 17, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 14, 2020 •
edited

Motivation for this change

was just released earlier today.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ludovicc
Copy link

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin
  • executables tested on Darwin
  • all depending packages build
Possible improvements
Comments

@jonringer jonringer merged commit 54dedd2 into NixOS:master Jul 17, 2020
@jonringer jonringer deleted the bump-azure-cli branch September 28, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @ludovicc