Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.haskell-language-server: 0.1.0.0 -> 0.2.0.0 #93150

Merged
merged 1 commit into from Jul 15, 2020
Merged

[haskell-updates] haskellPackages.haskell-language-server: 0.1.0.0 -> 0.2.0.0 #93150

merged 1 commit into from Jul 15, 2020

Conversation

maralorn
Copy link
Member

generated by
pkgs/development/tools/haskell/haskell-language-server/update.sh

with some manual tweaks, necessary because of old stack versions for lsp-test and hie-bios.

Thx to @GuillaumeDesforges , your update script made this a real breeze!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.haskell-language-server: 0.1.0.0 -> 0.2.0.0
db58471 
generated by
pkgs/development/tools/haskell/haskell-language-server/update.sh

with some manual tweaks
cdepillabout
cdepillabout approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is compiling on Linux, so looks good to me!

@maralorn maralorn merged commit c0b0dec into NixOS:haskell-updates Jul 15, 2020
@maralorn maralorn deleted the hls branch July 15, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout