Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwg-launchers: init at 0.2.0 #93189

Merged
merged 1 commit into from Jul 30, 2020
Merged

nwg-launchers: init at 0.2.0 #93189

merged 1 commit into from Jul 30, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jul 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

swaylock needs to be in path. I wonder if we should just wrap result/bin/nwgbar.

IvarWithoutBones
IvarWithoutBones requested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor nit, otherwise LGTM :)

pkgs/applications/misc/nwg-launchers/default.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Jul 16, 2020

Thanks!

@IvarWithoutBones
Copy link
Member

IvarWithoutBones commented Jul 17, 2020 •
edited

commits should be squashed, otherwise lgtm

@bbigras
Copy link
Contributor Author

bbigras commented Jul 17, 2020

Done. Yeah. AFAIK there's no way to accept a proposed change and squad it.

Mergers could use "the merge and squash button" but I know the policy is to squash manually.

@pbogdan pbogdan mentioned this pull request Jul 19, 2020
Closed
10 tasks
@berbiche
Copy link
Member

Relevant comment from the sgtk-menu PR #93456 (comment)

https://github.com/nwg-piotr/nwg-launchers/blob/43f7d5a21715f13f0b5c36529f6f407fc9fbb35a/bar/bar.json#L2-L6

@bbigras
Copy link
Contributor Author

bbigras commented Jul 21, 2020

Thanks @berbiche.

I updated the PR to wrap nwgbar. I think it might be simpler that way. It will work if someone is using his own bar.json.

The closure's size doesn't seem to change much:
/nix/store/nrhy46w551h9md9hbk69cckxlg76wwcr-nwg-launchers-0.2.0 182.1M
/nix/store/i5slffzzkv9fw98r4ybgdpq2mkkmmwix-nwg-launchers-0.2.0 197.0M (with swaylock)

We could have an option to wrap it optionally. And maybe have 2 version in all-packages.nix to ensure it's in the cache for everyone but I think it's simpler to just always wrap.

I'm very open to comments. Especially from people with more experience with Nix than me.

@bbigras
Copy link
Contributor Author

bbigras commented Jul 21, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 21, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 21, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jul 21, 2020

/state needs_review

@bbigras
Copy link
Contributor Author

bbigras commented Jul 21, 2020

/status needs_reviewer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/228

infinisil
infinisil approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think always wrapping is fine because it doesn't add that much.

@infinisil infinisil merged commit dd049a4 into NixOS:master Jul 30, 2020
@bbigras bbigras deleted the nwg-launchers branch July 30, 2020 16:56
@jtojnar jtojnar mentioned this pull request Aug 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbigras @IvarWithoutBones @berbiche @nixos-discourse @infinisil