Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-web: 1.6.7 -> 1.6.8 #93135

Merged
merged 1 commit into from Jul 14, 2020
Merged

riot-web: 1.6.7 -> 1.6.8 #93135

merged 1 commit into from Jul 14, 2020

Conversation

claudiiii
Copy link
Contributor

Motivation for this change

A new version was released recently: https://github.com/vector-im/riot-web/releases/tag/v1.6.8

This is required for #93134

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@claudiiii claudiiii mentioned this pull request Jul 14, 2020
Merged
10 tasks
rnhmjoj
rnhmjoj approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rnhmjoj rnhmjoj merged commit 406e29d into NixOS:master Jul 14, 2020
@claudiiii claudiiii deleted the update-riot-web branch February 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claudiiii @rnhmjoj