Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aerc: patch accounts.conf open permissions error #93178

Closed
wants to merge 1 commit into from
Closed

aerc: patch accounts.conf open permissions error #93178

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2020 •
edited by ghost

Motivation for this change

Blocks home-manager config implementation, see
nix-community/home-manager#1376 and
https://lists.sr.ht/~sircmpwn/aerc/%3C20200709211658.19070-1-me%40svmhdvn.name%3E

Things done

If the accounts.conf file contains secrets, it shouldn't be readable
to anyone except the owner of the file. Previously, aerc exits with an
error if this file is readable to other users, even if there are no
secrets in the file. This commit changes that behaviour to the
following:

  • Print a warning if the accounts.conf file is readable to other users
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and tadeokondrak July 15, 2020 13:39
tadeokondrak
tadeokondrak approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a similar but simpler patch locally already for the same problem.

@svmhdvn
Copy link
Contributor

svmhdvn commented Jul 15, 2020

Since we're not merging this patch upstream, would it be possible to make this even simpler by just turning the error into a warning on stderr?

@ghost ghost changed the title aerc: add do-not-fail-on-open-permissions.patch aerc: patch accounts.conf open permissions error Jul 15, 2020
aerc: patch accounts.conf open permissions error
6eaff3b 
If the accounts.conf file contains secrets, it shouldn't be readable
to anyone except the owner of the file. Previously, aerc exits with an
error if this file is readable to other users, even if there are no
secrets in the file. This commit changes that behaviour to the
following:
- Print a warning if the accounts.conf file is readable to other users
@ofborg ofborg bot requested a review from tadeokondrak July 15, 2020 23:01
@ghost
Copy link
Author

ghost commented Sep 17, 2020

Looks like this patch will go directly into home-manager. nix-community/home-manager#1376 (comment)

@ghost ghost closed this Sep 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmhdvn @tadeokondrak