Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.emoji-selector: init at v19 #93155

Merged
merged 1 commit into from Jul 16, 2020
Merged

gnomeExtensions.emoji-selector: init at v19 #93155

merged 1 commit into from Jul 16, 2020

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Jul 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from a team July 15, 2020 01:50
@rawkode rawkode force-pushed the package/gnome-emoji-selector branch 2 times, most recently from d76ebe7 to a980ed7 Compare July 15, 2020 08:17
@rawkode
Copy link
Member Author

rawkode commented Jul 15, 2020

Thanks, @jtojnar

@rawkode rawkode force-pushed the package/gnome-emoji-selector branch from a980ed7 to b387081 Compare July 15, 2020 08:24
@rawkode
Copy link
Member Author

rawkode commented Jul 16, 2020

@jtojnar could I get one last review please? I believe I've addresses these issues

@jtojnar jtojnar merged commit 332fa43 into NixOS:master Jul 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 16, 2020

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rawkode @jtojnar