Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl: issue a warning if defining a case after the default #435

Closed
wants to merge 1 commit into from

Conversation

FFY00
Copy link
Contributor

@FFY00 FFY00 commented Jul 14, 2020

Resolves #404

Signed-off-by: Filipe Laíns lains@archlinux.org

Resolves amaranth-lang#404

Signed-off-by: Filipe Laíns <lains@archlinux.org>
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #435 into master will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   81.71%   81.68%   -0.04%     
==========================================
  Files          40       40              
  Lines        6099     6103       +4     
  Branches     1242     1244       +2     
==========================================
+ Hits         4984     4985       +1     
- Misses        934      937       +3     
  Partials      181      181              
Impacted Files Coverage Δ
nmigen/hdl/dsl.py 98.94% <25.00%> (-0.79%) ⬇️
nmigen/build/run.py 31.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d714d78...6419e61. Read the comment docs.

@whitequark
Copy link
Member

Thank you for your contribution. I believe that #1059 will address the underlying issue.

@whitequark whitequark closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unused cases in a switch do not trigger warnings
2 participants