Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: 0.21.23 -> 0.21.25 #93143

Merged
merged 1 commit into from Jul 14, 2020
Merged

mpd: 0.21.23 -> 0.21.25 #93143

merged 1 commit into from Jul 14, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jul 14, 2020

Motivation for this change

Changelog at https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v0.21.25/NEWS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim tobim requested a review from doronbehar July 14, 2020 20:00
@doronbehar
Copy link
Contributor

LGTM if ofborg tests go well.

@ofborg ofborg bot requested review from fpletz, astsmtl and ehmry July 14, 2020 20:08
@marsam marsam merged commit c08ef80 into NixOS:master Jul 14, 2020
deviant added a commit to deviant/nixpkgs that referenced this pull request Oct 19, 2020
@deviant
mpd: remove unused fetchpatch argument
3c78241 
This argument is no longer referenced anywhere as of NixOS#93143.
@deviant deviant mentioned this pull request Oct 19, 2020
Merged
10 tasks
alyssais pushed a commit that referenced this pull request Oct 26, 2020
@deviant @alyssais
mpd: remove unused fetchpatch argument
99fabc5 
This argument is no longer referenced anywhere as of #93143.
@tobim tobim deleted the mpd/0.21.25 branch November 17, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

@fpletz fpletz Awaiting requested review from fpletz

@astsmtl astsmtl Awaiting requested review from astsmtl

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @doronbehar @marsam