Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune-release: 1.3.3 → 1.4.0 #93168

Merged
merged 1 commit into from Aug 2, 2020
Merged

Conversation

sternenseemann
Copy link
Member

Motivation for this change

https://github.com/ocamllabs/dune-release/releases/tag/1.4.0

Things done

Required a bit of fiddling around to get the mdx tests to work, but seems good now. yes for some reason would complain about a broken pipe in the no_doc test which I couldn't reproduce outside of nix-build. Seems to be safe to just ignore by piping it to /dev/null which makes the output match up again. No idea what's causing this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build dune-release

@vbgl
Copy link
Contributor

vbgl commented Aug 2, 2020

@GrahamcOfBorg build ocamlPackages.dune-release

@vbgl vbgl merged commit b37f774 into NixOS:master Aug 2, 2020
@sternenseemann sternenseemann deleted the dune-release-1.4.0 branch August 2, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants