element-desktop, element-web: init at 1.7.0 #93134
Conversation
| src = fetchFromGitHub { | ||
| owner = "vector-im"; | ||
| repo = "riot-desktop"; | ||
| rev = "v${version}"; | ||
| sha256 = "0l1ih7rkb0nnc79607kkg0k69j9kwqrczhgkqzsmvqxjz7pk9kgn"; | ||
| sha256 = "1igln0a8inxamknsds524k8k7934frc7jjn6y9bn43d0mq2j2vh4"; | ||
| }; | ||
| electron = electron_7; |
There was a problem hiding this comment.
Riot uses Electron 9 since v1.6.8-rc1 (changelog: https://github.com/vector-im/riot-desktop/blob/develop/CHANGELOG.md#changes-in-168-rc1-2020-07-01).
There was a problem hiding this comment.
It works with Electron 9 but mesa complains about missing iris drivers and there is no tray icon. But this might only be a problem on 20.03 and not unstable.
There was a problem hiding this comment.
The openGL driver is a constant source of troubles when testing new updates, because of the /run/opengl-driver impurity. This should probably be tested by rebuilding the system at this PR revision and boot into it, or in a VM.
|
1.7.0 is out now. Also, please squash your commits together. And for the future, it's sufficient to open up a single PR for both packages. |
|
@Ma27 How should I handle the name change form Riot to Element? Rename the files but keep the riot-* entries in all-packages, or keep the riot name for now? |
|
rename in all-packages.nix and keep the aliases in |
claudiiii
changed the title
|
I updated everything to 1.7.0 and changed the name. |
ofborg
bot
added
2.status: merge conflict
8.has: clean-up
8.has: package (new)
and removed
2.status: merge conflict
labels
|
Tested |
|
Did this rename incur some sort of breaking change that we have to backport to the release? |
|
Good question; Is it also using a different directory for the user data? If not, is it migrating accounts automatically? Porting this to the stable branch might not be straightforward as this new version depends on Electron 9, which isn't available on release-20.03. |
|
The NixOS manual also needs to be changed. The matrix synapse section mentions and explain how to serve riot-web. |
|
Account data will be read from the old Riot.im location. I didn't need to change anything. Electron 9 works on 20.03, couldn't it be backported as well? |
|
Hmm, for some reason the desktop item was not being associated with the proper icon for me. |
|
Interesting they just released 1.7.1 wich adds the new icons, I'll open a new pr with the update. Edit: I opened #93303 which should fix the icons. |
|
@worldofpeace I haven't taken a closer look. I can update the package and docs tomorrow amd perform a backbport if needed. |
|
@Ma27 It seems @claudiiii opened #93303. Docs still need to be updated though 👍 |
|
@worldofpeace @claudiiii due to the bgufixes on e.g. 1.7.1, does it make sense to backport this? (thanks to the aliases that should be ok I guess). |
Motivation for this change
A new version of riot-desktop was released a while ago: https://github.com/vector-im/riot-desktop/releases/tag/v1.6.8See #93135 forriot-web.Riot 1.7.0 is now Element, I changed everything from Riot to Element.
I tried to include
keytarandmatrix-seshat(#87752) but didn't find a way to build them, maybe someone with more knowledge of nodejs / yarn2nix in nix can help?Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)