Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.WWWCurl: fix build #93185

Merged
merged 1 commit into from Jul 17, 2020
Merged

perlPackages.WWWCurl: fix build #93185

merged 1 commit into from Jul 17, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jul 15, 2020

Include patch from AUR to fix compatibility with newer libcurl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from volth and aanderse July 15, 2020 15:02
@veprbl
Copy link
Member

veprbl commented Jul 15, 2020

@GrahamcOfBorg build perl530Packages.WWWCurl perl528Packages.WWWCurl

@stigtsp
Copy link
Member Author

stigtsp commented Jul 16, 2020

Fixed darwin build issue.

@stigtsp stigtsp force-pushed the package/perl-www-curl-fix branch 2 times, most recently from 8d5d994 to b8612cb Compare July 16, 2020 01:01
@veprbl
Copy link
Member

veprbl commented Jul 16, 2020

@GrahamcOfBorg build perl530Packages.WWWCurl perl528Packages.WWWCurl

@stigtsp
perlPackages.WWWCurl: fix build
a05489f 
- Include patch from AUR to fix compatibility with newer libcurl.
- Fix build with clang
@veprbl
Copy link
Member

veprbl commented Jul 17, 2020

@GrahamcOfBorg build perl530Packages.WWWCurl perl528Packages.WWWCurl

@veprbl veprbl merged commit a9ddda9 into NixOS:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @veprbl