Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hwi: init at 1.1.2 #93182

Merged
merged 1 commit into from Aug 3, 2020
Merged

python3Packages.hwi: init at 1.1.2 #93182

merged 1 commit into from Aug 3, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 15, 2020 •
edited

Motivation for this change

New package to interact with Hardware Wallets

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from mmahut July 15, 2020 14:40
jonringer
jonringer reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that hwi is exposed, is this normally used a python application? if so, please expose the command in all-packages.nix

  hwi = with python3Packages; toPythonApplication hwi;

pkgs/development/python-modules/hwi/default.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member Author

prusnak commented Jul 16, 2020

if so, please expose the command in ...

Done in 12d2621

jonringer
jonringer approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

[4 built, 44 copied (14.8 MiB), 2.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/93182
2 packages built:
hwi python37Packages.hwi

@jonringer jonringer merged commit 64a8d01 into NixOS:master Aug 3, 2020
@prusnak prusnak deleted the hwi branch August 4, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @jonringer