singularity: 3.2.1 -> 3.6.1 #93165
Merged
singularity: 3.2.1 -> 3.6.1 #93165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this also broken in 20.03? |
Mic92
reviewed
Jul 15, 2020
| make -C builddir install LOCALSTATEDIR=$out/var | ||
| chmod 755 $out/libexec/singularity/bin/starter-suid | ||
| wrapProgram $out/bin/singularity --prefix PATH : ${stdenv.lib.makeBinPath propagatedBuildInputs} | ||
| runHook postInstall | ||
| ''; | ||
|
|
||
| postFixup = '' | ||
| find $out/libexec/ -type f -executable -exec remove-references-to -t ${go} '{}' + || true |
There was a problem hiding this comment.
Different PR, but should we include $out/libexec in buildGoPackage as well for removing references?
There was a problem hiding this comment.
I think it would be valuable to do so, libexec is part of the FHS so we should expect some binaries to land there.
Mic92
reviewed
Jul 15, 2020
Mic92
reviewed
Jul 15, 2020
Mic92
reviewed
Jul 15, 2020
Partially broken, some functionality works (building images) but running images fails. Would be worth backporting this to 20.03. |
|
They cut a new release which fixes a security bug and resolves the hardening issues. I've updated and we now don't need to disable hardening. |
|
Result of 1 package built:- singularity |
|
Please backport if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest release. Resolves #92466 and also a hardening bug.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)