Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kepubify: Update my GitHub username #93147

Merged
merged 1 commit into from Jul 16, 2020
Merged

kepubify: Update my GitHub username #93147

merged 1 commit into from Jul 16, 2020

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Jul 14, 2020

Motivation for this change

I changed my GitHub username from @geek1011 to @pgaskin.

Note that I'm also releasing v3.1.4, but I'll leave that to @r-ryantm to update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

zowoq
zowoq approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pgaskin!

@zowoq zowoq merged commit 752ea30 into NixOS:master Jul 16, 2020
@pgaskin pgaskin deleted the kepubify-gh-username branch July 16, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgaskin @zowoq @Janik-Haag