Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5743e3b42399
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 51cc0a2dbfe3
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Aug 2, 2020

  1. Copy the full SHA
    aa112c7 View commit details

Commits on Aug 3, 2020

  1. Merge pull request #2662 from eggrobin/fix-collision-warning

    Fix the collision warning for bodies with oceans
    eggrobin authored Aug 3, 2020
    Copy the full SHA
    51cc0a2 View commit details
Showing with 4 additions and 3 deletions.
  1. +4 −3 ksp_plugin_adapter/orbit_analyser.cs
7 changes: 4 additions & 3 deletions ksp_plugin_adapter/orbit_analyser.cs
Original file line number Diff line number Diff line change
@@ -251,9 +251,10 @@ private void RenderOrbitalElements(OrbitalElements? elements,
LabeledField(
"Lowest altitude",
(lowest_distance - primary?.Radius)?.FormatAltitude());
double? lowest_primary_altitude =
primary?.ocean == true ? 0 : primary?.pqsController?.radiusMin;
string altitude_warning = lowest_distance < lowest_primary_altitude
double? lowest_primary_distance = primary?.ocean == true
? primary.Radius
: primary?.pqsController?.radiusMin;
string altitude_warning = lowest_distance < lowest_primary_distance
? "collision"
: lowest_distance < primary?.pqsController?.radiusMax
? "collision risk"