Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpytop: init at 1.0.0 #94625

Merged
merged 1 commit into from Aug 4, 2020
Merged

bpytop: init at 1.0.0 #94625

merged 1 commit into from Aug 4, 2020

Conversation

herrwiese
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

endgame
endgame approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on nixos using nix-build -A bpytop https://github.com/herrwiese/nixpkgs/archive/a06c7543be32f66f8dc4ef4df5a307fa3bd5461c.tar.gz, though it did make my eyes hurt. I assume that's just the default theme =)

pkgs/tools/system/bpytop/default.nix Show resolved Hide resolved
@sikmir
Copy link
Member

sikmir commented Aug 4, 2020

Built on darwin, but "Segmentation fault: 11" while "Collecting data and drawing...".

@herrwiese
Copy link
Contributor Author

Built on darwin, but "Segmentation fault: 11" while "Collecting data and drawing...".

I added meta.broken = stdenv.isDarwin; for now. Unfortunately I don't have any Darwin machine to investigate myself.

@endgame
Copy link
Contributor

endgame commented Aug 4, 2020

I added meta.broken = stdenv.isDarwin; for now.

I think you want to set platforms = platforms.linux instead?

@herrwiese
Copy link
Contributor Author

I added meta.broken = stdenv.isDarwin; for now.

I think you want to set platforms = platforms.linux instead?

According to upstream it should be working on Linux, FreeBSD and OSX, so yes, I think I don't want platforms.unix (fixed that), but the broken stance should still be correct, shouldn't it?

@Ma27 Ma27 merged commit edd9e3e into NixOS:master Aug 4, 2020
@herrwiese herrwiese deleted the for-master/bpytop branch September 7, 2020 09:16
@hacker1024
Copy link
Member

Looks okay on Darwin now.

This was referenced Nov 3, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@endgame endgame endgame approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@herrwiese @sikmir @endgame @hacker1024 @Ma27