@rycee Will you take a look?

I'm not too sure about having this. I personally think it entirely fine to have these infobars, and don't they go away after first use?

In the past we had issue with the stylesheet not being used on other platforms, but that got resolved cassidyjames/ephemeral#122

@worldofpeace

I'm not too sure about having this. I personally think it entirely fine to have these infobars, and don't they go away after first use?

It appears that there's is some sort of a countdown: https://github.com/cassidyjames/ephemeral/blob/main/src/InfoBars/PaidInfoBar.vala
Also I can confirm that both infobars will show again after some time.

I don't see a problem with including this patch as it is optional and users can choose to enable it if they're aware of the "warnings".

If you want I can break the patch into two - one for each infobar.

@flokli Do you have any take on this?
Personally I see no problem in an optional patch to reverse some booleans.

I don't have any opinion on that, sorry.

It seems to me that it should be OK to merge this. Since the patch is disabled by default I think that the intent of the Ephemeral developers is honored. The patch would only be enabled by conscious decision corresponding to the user consciously closing the bars within the application. So, unless any objection arises I will merge this in a few days (Aug 22 or 23).

It seems to me that it should be OK to merge this. Since the patch is disabled by default I think that the intent of the Ephemeral developers is honored. The patch would only be enabled by conscious decision corresponding to the user consciously closing the bars within the application. So, unless any objection arises I will merge this in a few days (Aug 22 or 23).

My main objections are that I'd have to maintain the patch (likely indefinitely) and there's actually better ways that we could handle this that upstream could accept.

Is the issue here that the infobars appear after sometime instead of staying "dismissed"?

TBH, the more expected behavior is that there is a key that would have the same of the infobars in it, and once that key gets added those values (by virtue of you dismissing it) it's stored that those infobars are viewed and they aren't shown again. But I can see for the developers that's not a good way to get payed for your work 😁

In the source code they should be shown once a month https://github.com/cassidyjames/ephemeral/blob/main/src/Application.vala#L33, I think that's incredibly reasonable. So I don't think I'd propose to the devs to "just please only show this once", but instead how about warn_native_for_session and warn_paid_for_session can become gsettings (maybe not configurable in the ui either). The distributor could then ship a dconf override with the application to then disable these.

Let me know what you think so we could perhaps open an issue. My current disposition on this patch is to not accept it.
Considering I'm it's maintainer I will close the PR for now.

@cassidyjames What do you think about the above? IMHO these infobars are fine to show and the duration is a very reasonable choice, but it seems maybe downstreams could configure it with a key that isn't shown in the UI?

@worldofpeace Thanks for the nice response. Sounds fair to me.