Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

real_time_config_quick_scan:unstable-2020-08-03 -> unstable-2020-07-23 #94621

Merged
merged 1 commit into from Aug 3, 2020
Merged

real_time_config_quick_scan:unstable-2020-08-03 -> unstable-2020-07-23 #94621

merged 1 commit into from Aug 3, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 3, 2020 •
edited

also resolve suggestions from #78998

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon mentioned this pull request Aug 3, 2020
Merged
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Aug 3, 2020 •
edited

Why the downgrade? edit: looks like it previously used 2020 instead of 2019 incorrectly.

@jtojnar jtojnar merged commit e6ff470 into NixOS:master Aug 3, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 3, 2020

Thanks.

@magnetophon magnetophon deleted the real_time_config_quick_scan branch August 3, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @jtojnar