Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mamba: init at 1.3 #94615

Merged
merged 2 commits into from Aug 16, 2020
Merged

mamba: init at 1.3 #94615

merged 2 commits into from Aug 16, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 3, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

0x4A6F
0x4A6F requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Currently I don't have a system with JACK as audio system and can only see a working interface when starting mamba.

pkgs/applications/audio/mamba/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mamba/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mamba/default.nix Outdated

nativeBuildInputs = [ pkgconfig ];
buildInputs = [
xorg.libX11 xorg.libpthreadstubs cairo libjack2 pcre libXdmcp libsigcxx liblo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format your contributions with nixpkgs-fmt?
(i.e. nix run -f channel:nixos-unstable nixpkgs-fmt -c nixpkgs-fmt pkgs/applications/audio/mamba/default.nix)

pkgs/applications/audio/mamba/default.nix Outdated
@@ -0,0 +1,28 @@
{ stdenv, fetchFromGitHub, xorg, cairo, libjack2, pcre, libXdmcp, libsigcxx, liblo, pkgconfig }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also format the input function like so:
{ stdenv
, fetchFromGitHub
, ...
}:

This makes future diffs more readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done, thanks for the feedback!

@magnetophon
Copy link
Member Author

Currently I don't have a system with JACK as audio system and can only see a working interface when starting mamba.

I'm not following, sorry.

0x4A6F
0x4A6F approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • running on aarch64-linux
./result/bin/mamba 
Samplerate 48000Hz 
Buffersize is 1024 samples 
jack running with realtime priority
Xrun

Thanks for the changes.

@orivej
Copy link
Contributor

orivej commented Aug 16, 2020

I've upstreaming the changes from fix-build.patch in brummer10/libxputty#4 and brummer10/Mamba#7.

@magnetophon
Copy link
Member Author

@orivej Thanks! Shall I update the PR to point at those commits?

@magnetophon magnetophon changed the title mamba: init at 1.1 mamba: init at 1.3 Aug 16, 2020
@orivej
Copy link
Contributor

orivej commented Aug 16, 2020

No, let's drop the patch during the next update. (It will be obvious that it is no longer needed since patch will ask to reverse an already applied patch.)

@orivej-nixos orivej-nixos merged commit c8003b5 into NixOS:master Aug 16, 2020
@magnetophon magnetophon deleted the mamba branch August 17, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @orivej @0x4A6F @orivej-nixos