Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dokuwiki: drop SSL forcing and document incompatibility #94609

Merged
merged 3 commits into from Aug 5, 2020
Merged

nixos/dokuwiki: drop SSL forcing and document incompatibility #94609

merged 3 commits into from Aug 5, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Aug 3, 2020 •
edited

Motivation for this change

Dropping configuration which was forcing user to use Let's encrypt and SSL as default. It was non-intuitive and causing problems in some configurations.

Moreover, I've documented breaking changes introduced in #83769.

Following up on #94551.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101 1000101 mentioned this pull request Aug 3, 2020
Merged
10 tasks
@1000101 1000101 requested a review from aanderse August 3, 2020 14:22
@1000101
Copy link
Member Author

1000101 commented Aug 3, 2020

@GrahamcOfBorg test dokuwiki

@mmahut mmahut merged commit 0bc37f7 into NixOS:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadada dadada dadada approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1000101 @dadada @mmahut