Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jailbreak rebase on ghc 8.6 #92748

Closed
wants to merge 8 commits into from
Closed

jailbreak rebase on ghc 8.6 #92748

wants to merge 8 commits into from

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Jul 8, 2020 •
edited

Motivation for this change

Rebase depends on time 1.9.*, which apparently isn't the version in nixpkgs master.
This change allows rebase and all packages that depend on it to compile.
This surfaced while building haskell-language-server for ghc 8.6.5 (see this thread)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti added 7 commits July 4, 2020 02:30
@peti
hackage-packages.nix: automatic Haskell package set update
30199d5 
This update was generated by hackage2nix v2.15.5-9-gcc12216 from Hackage revision
commercialhaskell/all-cabal-hashes@d88cd00.
@peti
hackage-packages.nix: automatic Haskell package set update
c64d908 
This update was generated by hackage2nix v2.15.5-9-gcc12216 from Hackage revision
commercialhaskell/all-cabal-hashes@94931cf.
@peti
hackage-packages.nix: automatic Haskell package set update
b814597 
This update was generated by hackage2nix v2.15.5-9-gcc12216 from Hackage revision
commercialhaskell/all-cabal-hashes@237a3e3.
@peti
LTS Haskell 16.4
c149bcf
@peti
hackage-packages.nix: automatic Haskell package set update
bbaab2f 
This update was generated by hackage2nix v2.15.5-8-g13e29eb from Hackage revision
commercialhaskell/all-cabal-hashes@5381b7d.
@peti
hackage-packages.nix: automatic Haskell package set update
e5f219a 
This update was generated by hackage2nix v2.15.5-9-gcc12216 from Hackage revision
commercialhaskell/all-cabal-hashes@123ad4e.
@peti
hackage-packages.nix: automatic Haskell package set update
48c68a5 
This update was generated by hackage2nix v2.15.5-9-gcc12216 from Hackage revision
commercialhaskell/all-cabal-hashes@04df818.
@cdepillabout
Copy link
Member

cdepillabout commented Jul 9, 2020 •
edited

@GrahamcOfBorg build haskell.packages.ghc865.rebase

(@414owen In the future, please format commit messages as recommended in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. This commit might be called something like haskell.packages.ghc865.rebase: jailbreak on ghc 8.6. This helps ofborg run automatically.)

@cdepillabout
Copy link
Member

@414owen One more thing, could you rebase this on the haskell-updates branch? Normally we merge all the Haskell stuff into haskell-updates.

@414owen 414owen force-pushed the jailbreak-rebase-on-ghc-8.6 branch from 759daa2 to de900ef Compare July 9, 2020 09:05
@414owen
Copy link
Contributor Author

414owen commented Jul 9, 2020

Closing in favor of #92777

@414owen 414owen closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@414owen @cdepillabout @Janik-Haag @peti