Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Abstract portal activation handling to avoid hack of making a fake promise." #24526

Merged
merged 1 commit into from Jul 9, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 9, 2020

This reverts commit fdc228c7acab87083507a1276f9d8f786966f5d6.

Reason for revert: portal-activate-default.html test timeout failure
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803

Original change's description:

Abstract portal activation handling to avoid hack of making a fake promise.

This is somewhat verbose, but allows us to avoid the unhandled rejection
being visible to script without having to make this hack even worse.

Instead of actually calling activate(), this mirrors the spec structure
by simply calling to underlying logic, passing a resolver where it makes
sense and not (in this case, passing a substitute object) where it
doesn't.

Bug: 1102081
Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786480}

TBR=jbroman@chromium.org,adithyas@chromium.org

Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288712
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786596}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

… fake promise."

This reverts commit fdc228c7acab87083507a1276f9d8f786966f5d6.

Reason for revert: portal-activate-default.html test timeout failure
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803

Original change's description:
> Abstract portal activation handling to avoid hack of making a fake promise.
>
> This is somewhat verbose, but allows us to avoid the unhandled rejection
> being visible to script without having to make this hack even worse.
>
> Instead of actually calling activate(), this mirrors the spec structure
> by simply calling to underlying logic, passing a resolver where it makes
> sense and not (in this case, passing a substitute object) where it
> doesn't.
>
> Bug: 1102081
> Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786480}

TBR=jbroman@chromium.org,adithyas@chromium.org

Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288712
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786596}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants