Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certbot: 1.3.0 -> 1.6.0 #92696

Merged
merged 4 commits into from Jul 9, 2020
Merged

certbot: 1.3.0 -> 1.6.0 #92696

merged 4 commits into from Jul 9, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 8, 2020

This includes certbot/certbot#8081, so we can
stop shipping our custom patch to workaroung things, and start packaging
more certbot plugins.

Other release notes:

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
certbot: 1.3.0 -> 1.6.0
7f6f990 
This includes certbot/certbot#8081, so we can
stop shipping our custom patch to workaroung things, and start packaging
more certbot plugins.

Other release notes:
 - https://github.com/certbot/certbot/releases/tag/v1.4.0
 - https://github.com/certbot/certbot/releases/tag/v1.5.0
 - https://github.com/certbot/certbot/releases/tag/v1.6.0
@ofborg ofborg bot requested a review from domenkozar July 8, 2020 10:02
@flokli flokli requested a review from jonringer as a code owner July 8, 2020 11:37
@flokli
Copy link
Contributor Author

flokli commented Jul 8, 2020

I added 3 common DNS plugins I might end up using - the others should be simple enough to be packaged once someone starts using them.

I was able to access these plugins from a nix-shell containing the additional python package, so I assume adding them to PYTHONPATH is all that's needed.

@FRidh, @domenkozar, do you have any opinions on a certbotWithPackages, certbot-full or similar?

@flokli flokli requested a review from mweinelt July 8, 2020 11:46
@flokli
Copy link
Contributor Author

flokli commented Jul 8, 2020

cc @NixOS/acme

@prusnak prusnak removed their request for review July 8, 2020 21:45
@m1cr0man
Copy link
Contributor

m1cr0man commented Jul 8, 2020

Is the intention long-term to replace lego with cerbot? If so, I might just do it during my rewrite.

@flokli
Copy link
Contributor Author

flokli commented Jul 8, 2020 via email

@picnoir
Copy link
Member

picnoir commented Jul 9, 2020 •
edited

nix-build -A pythonPackages.certbot-dns-cloudflare is failing.

We probably want to remove these packages from the python2 packageset.

picnoir
picnoir reviewed Jul 9, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portability nitpick.

Other than that, LGTM

pkgs/development/python-modules/certbot-dns-cloudflare/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/certbot-dns-rfc2136/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/certbot-dns-route53/default.nix Outdated Show resolved Hide resolved
@flokli flokli requested a review from picnoir July 9, 2020 09:22
picnoir
picnoir approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flokli
Copy link
Contributor Author

flokli commented Jul 9, 2020

@GrahamcOfBorg build certbot

@picnoir picnoir merged commit 074d131 into NixOS:master Jul 9, 2020
@flokli flokli deleted the certbot-1.6.0 branch July 9, 2020 09:56
@flokli flokli mentioned this pull request Jul 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

@jonringer jonringer Awaiting requested review from jonringer

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @m1cr0man @picnoir