Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb: 4.0.12 -> 4.2.8 #92719

Merged
merged 1 commit into from Jul 24, 2020
Merged

mongodb: 4.0.12 -> 4.2.8 #92719

merged 1 commit into from Jul 24, 2020

Conversation

pjjw
Copy link
Contributor

@pjjw pjjw commented Jul 8, 2020 •
edited

Not strictly an upgrade, but adds a new mongodb-4_2 target with the
current mongodb from that branch.

Motivation for this change

Current mongodb isn't packaged, would like it to be.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pjjw pjjw requested review from FRidh and jonringer as code owners July 8, 2020 15:04
@pjjw
Copy link
Contributor Author

pjjw commented Jul 11, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 11, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 11, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from fgaz July 14, 2020 19:40
@timokau timokau mentioned this pull request Jul 14, 2020
Open
fgaz
fgaz approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks fine (didn't look at the .patches). Some style suggestions.

pkgs/development/python-modules/cheetah3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cheetah3/default.nix Outdated Show resolved Hide resolved
pkgs/servers/nosql/mongodb/mongodb.nix Outdated Show resolved Hide resolved
pkgs/servers/nosql/mongodb/mongodb.nix Show resolved Hide resolved
pkgs/development/python-modules/cheetah3/default.nix Show resolved Hide resolved
@pjjw pjjw force-pushed the update/mongodb-42 branch 2 times, most recently from 73d9c84 to 341ae3f Compare July 19, 2020 22:03
@pjjw
Copy link
Contributor Author

pjjw commented Jul 19, 2020

addressed comments, squashed out the errors i'd made, noticed that github doesn't preserve that history- apologies for that. regardless, PTAL. thanks!

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 20, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@fgaz
Copy link
Member

fgaz commented Jul 20, 2020

@GrahamcOfBorg build mongodb-4_2

@fgaz
Copy link
Member

fgaz commented Jul 20, 2020

Oh, right. It's unfree now.

@pjjw
Copy link
Contributor Author

pjjw commented Jul 20, 2020

actually just caught an issue with tests- current test is using cross-version clients, and 3.4 to 4.2 doesn't work. quick update inbound.

@pjjw pjjw requested a review from fgaz July 21, 2020 16:54
@fgaz fgaz requested review from phile314 and rvl July 24, 2020 09:35
fgaz
fgaz approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinged a few more people that were in the maintainer list. If no one replies in a couple days I'll just set this to needs_merge

@fgaz
Copy link
Member

fgaz commented Jul 24, 2020

In the meantime please prefix the commit messages with their scope, like you did on the first one

@pjjw
Copy link
Contributor Author

pjjw commented Jul 24, 2020

sure. mind if i just squash them out now that you've reviewed?

@fgaz
Copy link
Member

fgaz commented Jul 24, 2020

That's also fine, yes

@pjjw
mongodb: 4.0.12 -> 4.2.8
dbd0f3e 
Not strictly an upgrade, but adds a new mongodb-4_2 target with the
current mongodb from that branch.

Use matching client and server versions in mongodb tests- tests were
using the mongo 3.4 client to connect, and this finally doesn't work
with server 4.2.

Per reviewer suggestion, adding myself as cheetah3 maintainer.

Additionally, reestore comments describing the purpose of the
build-dependencies patch
@fgaz
Copy link
Member

fgaz commented Jul 24, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau July 24, 2020 16:45
@offlinehacker offlinehacker merged commit fea9351 into NixOS:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

@phile314 phile314 phile314 approved these changes

@fgaz fgaz fgaz approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@cstrahan cstrahan Awaiting requested review from cstrahan

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@rvl rvl Awaiting requested review from rvl

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pjjw @fgaz @offlinehacker @phile314 @Janik-Haag