python3Packages.west: init at 0.7.2 #92713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jul 8, 2020
| checkInputs = [ | ||
| pytest | ||
| ]; | ||
|
|
There was a problem hiding this comment.
There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.
If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.
----------------------------------------------------------------------
Ran 0 tests in 0.000s
There was a problem hiding this comment.
Good point, thank you. Fixed and force-pushed.
siriobalmelli
force-pushed
the
add/west
branch
4 times, most recently
from
65483b9
to
2958efa
Compare
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch> Co-authored-by: Joh <jonringer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sirio Balmelli sirio@b-ad.ch
Motivation for this change
Require
westfor an embedded toolchain using ZephyrThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)