Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-3] Add letter-spacing tests written last October #24516

Merged
merged 10 commits into from Jul 9, 2020

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Jul 8, 2020

No description provided.

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frivoal
Copy link
Contributor

frivoal commented Jul 9, 2020

See fantasai#1 for proposed fixes to this PR.

Probably leftover from copying the test file to create the ref.
This included a circular reference claiming the ref was its own ref.
Remove unnecessary decorations only present in the test but not in the
ref
* Remove inconsistencies in unessential decorations between test and ref
* Correct manual calculations of letter spacing in the "control" block
* Fix application of white-space property in ref file
* Remove unnecessary decorations

* Remove the width constraint: it causes line breaks and these interfere
with the presence of letter-spacing in a way that isn't tracked by that
test. Other tests take care of end-of-line letter-spacing.
* Make assert consistent with the test (and the spec)
* Remove unnecessary decorations
* Complete the ref to match the test
* Add support file
* Don't use proprietary properties
* Remove dead code
* Add missing ref file
* Remove unnecessary decorations
* Delete leftover code
* Set up the ref file
There are plenty of test checking whether letter spacing adds a space at
the end of the line or not. Confirming that is not the point of these
two tests, especially given that that is still a controvertial topic,
while the point of this test is not.

This commit makes the tests work regardless of how end of lines are
handled.
@fantasai fantasai merged commit 3e6a569 into web-platform-tests:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants