Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.accerciser: 3.36.1 -> 3.36.2 #92742

Merged
merged 1 commit into from Jul 9, 2020
Merged

gnome3.accerciser: 3.36.1 -> 3.36.2 #92742

merged 1 commit into from Jul 9, 2020

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jul 8, 2020 •
edited by jtojnar

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/accerciser/versions.

meta.description for gnome3.accerciser is: "Interactive Python accessibility explorer"

meta.homepage for gnome3.accerciser is: "https://wiki.gnome.org/Apps/Accerciser"

meta.changelog for gnome3.accerciser is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
gnome3.accerciser
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gnome3.accerciser https://github.com/r-ryantm/nixpkgs/archive/dc6f8805824cd53ab2273dd9425a36310f0b7246.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2
ls -la /nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- gnome3.accerciser
Maintainer pings

cc @hedning @jtojnar @worldofpeace @dasj19 for testing.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jul 8, 2020
@ofborg ofborg bot requested review from worldofpeace, jtojnar and hedning July 8, 2020 19:40
@dasj19
Copy link
Contributor

dasj19 commented Jul 9, 2020

I tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 92742" and I can see a couple of issues.

  1. Warning when starting from terminal:
(.accerciser-wrapped:24913): Wnck-WARNING **: 21:59:45.656: libwnck is designed to work in X11 only, no valid display found
  1. The program opens with a module error:
io.UnsupportedOperation: fileno
Traceback (most recent call last):
  File "/nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2/lib/python3.8/site-packages/accerciser/plugin/plugin_manager.py", line 192, in _enablePlugin
    plugin_instance.init()
  File "/nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2/share/accerciser/plugins/console.py", line 42, in init
    self.ipython_view = ipython_view.IPythonView()
  File "/nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2/share/accerciser/plugins/ipython_view.py", line 587, in __init__
    IterableIPShell.__init__(self, cout=self.cout, cerr=self.cout,
  File "/nix/store/wgvbjz4zzdnk1sghqzdh3pifjc03iynl-accerciser-3.36.2/share/accerciser/plugins/ipython_view.py", line 111, in __init__
    self.IP = IPython.terminal.embed.InteractiveShellEmbed.instance(\
  File "/nix/store/q7pcs8cx7vrn9cc45qglnxq1hw0v8ic5-python3.8-traitlets-4.3.3/lib/python3.8/site-packages/traitlets/config/configurable.py", line 412, in instance
    inst = cls(*args, **kwargs)
  File "/nix/store/q05pln6d210hzgc6x8ycjx3cc55h4rnm-python3.8-ipython-7.15.0/lib/python3.8/site-packages/IPython/terminal/embed.py", line 159, in __init__
    super(InteractiveShellEmbed,self).__init__(**kw)
  File "/nix/store/q05pln6d210hzgc6x8ycjx3cc55h4rnm-python3.8-ipython-7.15.0/lib/python3.8/site-packages/IPython/terminal/interactiveshell.py", line 525, in __init__
    self.init_prompt_toolkit_cli()
  File "/nix/store/q05pln6d210hzgc6x8ycjx3cc55h4rnm-python3.8-ipython-7.15.0/lib/python3.8/site-packages/IPython/terminal/interactiveshell.py", line 318, in init_prompt_toolkit_cli
    self.pt_app = PromptSession(
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/shortcuts/prompt.py", line 458, in __init__
    self.app = self._create_application(editing_mode, erase_when_done)
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/shortcuts/prompt.py", line 701, in _create_application
    application: Application[_T] = Application(
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/application/application.py", line 266, in __init__
    self.output = output or session.output
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/application/current.py", line 65, in output
    self._output = create_output()
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/output/defaults.py", line 62, in create_output
    return Vt100_Output.from_pty(stdout, term=get_term_environment_variable())
  File "/nix/store/87v1fnfbmr86mqw0mf5xi77i7p9m15wq-python3.8-prompt_toolkit-3.0.5/lib/python3.8/site-packages/prompt_toolkit/output/vt100.py", line 449, in from_pty
    fd = stdout.fileno()
io.UnsupportedOperation: fileno
  1. It suffers the same as brasero from a missing thumbnail icon when Alt-Tab'ing (see brasero: displays generinc icon when Alt-Tab'ing in Gnome #92585)

@jtojnar
Copy link
Contributor

jtojnar commented Jul 9, 2020 •
edited

  1. Yeah, libwnck will probably never support Wayland.
  2. I can see that in 3.36.1 too, and I am pretty sure this worked when I last tested, perhaps some dependency (like IPython) broke compatibility.
  3. Yeah, I think all wrapped scripts (that do not override the program name) will be affected. This is Python app so it is a script.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 9, 2020

Changes look okay.

@jtojnar jtojnar merged commit 4975176 into NixOS:master Jul 9, 2020
@r-ryantm r-ryantm deleted the auto-update/accerciser branch July 11, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-ryantm @dasj19 @jtojnar