Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis option in VTR does not generate Blackbox timing in SDF correctly #537

Open
tpagarani opened this issue Jul 8, 2020 · 4 comments

Comments

@tpagarani
Copy link

There are multiple issues related to SDF writer for Blackbox primitive

  1. The primitives being modeled as Blackbox have combinational and sequential timings. In present --analysis code, blackbox combinational and sequential timings are not getting populated

  2. Blackbox could have more than 1 reference clocks (e.g. Dual Port RAM). Current SDF generation does not handle timing checks w.r.t. specific clock. It uses a generic name "clk" to write out timing checks

Solution would be to traverse through all output and inputs pins of blackbox primitive to collect timing paths and
timing checks. Also store the correct reference clock during the traversal.

@mithro
Copy link
Member

mithro commented Jul 8, 2020

Should the timing information be provided by the black box implementation rather than vpr?

@mithro
Copy link
Member

mithro commented Jul 8, 2020

@kgugala / @acomodi

@tpagarani
Copy link
Author

@mithro, well the reason I mention VPR is that sdf writer is part of VPR. Timing graph already has timing arcs and setup/hold, it's just that it's not being written out in SDF. I have already coded a fix in netlist_writer and in the process of creating a PR.

@mithro
Copy link
Member

mithro commented Jul 8, 2020

@tpagarani - Not opposed to seeing this happening, just wondering if that is a work around or solution which results in less duplication in the output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants