Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pounce: 1.1 -> 1.3p1 #92726

Merged
merged 1 commit into from Jul 9, 2020
Merged

pounce: 1.1 -> 1.3p1 #92726

merged 1 commit into from Jul 9, 2020

Conversation

glittershark
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@glittershark glittershark marked this pull request as draft July 8, 2020 16:31
@ofborg ofborg bot requested a review from edef1c July 8, 2020 16:37
@glittershark glittershark marked this pull request as ready for review July 8, 2020 16:39
causal-agent
causal-agent reviewed Jul 8, 2020
View reviewed changes
pkgs/servers/pounce/default.nix
buildInputs = [ libressl ];

configurePhase = "ln -s Linux.mk config.mk";
buildInputs = [ libressl pkg-config ];

buildFlags = [ "all" ];

makeFlags = [
"PREFIX=$(out)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be preferable to now set DESTDIR and PREFIX separately, although it doesn't matter to pounce.

@causal-agent
Copy link

Apparently as the author of pounce I should leave my seal of approval on this, so

LGTM :)

danieldk
danieldk suggested changes Jul 9, 2020
View reviewed changes
pkgs/servers/pounce/default.nix Outdated Show resolved Hide resolved
@glittershark
Copy link
Member Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 9, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 9, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@glittershark
Copy link
Member Author

/status needs_reviewer

danieldk
danieldk approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92726 1

1 package built:
- pounce

@danieldk danieldk merged commit 59864f6 into NixOS:master Jul 9, 2020
@glittershark glittershark deleted the bump-pounce branch July 9, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@causal-agent causal-agent causal-agent left review comments

@danieldk danieldk danieldk approved these changes

@edef1c edef1c Awaiting requested review from edef1c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 marvin needs_reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glittershark @causal-agent @danieldk