Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-tree: Expose as a top-level attribute, add maintainer #92752

Merged
merged 1 commit into from Jul 9, 2020
Merged

nix-tree: Expose as a top-level attribute, add maintainer #92752

merged 1 commit into from Jul 9, 2020

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented Jul 8, 2020

Motivation for this change

This PR exposes nix-tree as a top-level attribute (originally in haskellPackages), since it is useful outside of the Haskell ecosystem.

It also sets myself as the maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@utdemir Thanks for sending this. This looks like a good change to me.

Since you're touching configuration-hackage2nix.yaml here, could you rebase this on the haskell-updates branch? Once you do that this should be fine to merge in.

@utdemir utdemir force-pushed the expose-nix-tree-as-top-level-attribute branch from 2aef8c4 to eef4de4 Compare July 9, 2020 02:03
@utdemir
Copy link
Member Author

utdemir commented Jul 9, 2020

Thanks @cdepillabout , I rebased and force-pushed this branch. However it seems like GitHub doesn't allow changing the base branch of a PR. Can you merge this in this state, or is there anything else I should do?

@jtojnar
Copy link
Contributor

jtojnar commented Jul 9, 2020

You can change the base branch by clicking the edit button next to the title.

@utdemir utdemir changed the base branch from master to haskell-updates July 9, 2020 03:14
@utdemir
Copy link
Member Author

utdemir commented Jul 9, 2020

Thanks @jtojnar , just changed it.

@cdepillabout
Copy link
Member

@utdemir Thanks!

@cdepillabout cdepillabout merged commit d4c0ea2 into NixOS:haskell-updates Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@utdemir @cdepillabout @jtojnar