[LayoutNG] Only apply block-end margins where the block actually ends. #24522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 8, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2287313
branch
2 times, most recently
from
41764fc
to
bd67f1e
Compare
If we reached the end of a block in an earlier fragmentainer, but there's overflowing content, we'll revisit this block in subsequent fragmentainers as long as child content needs it. Repeating the block-end margins in these fragmentainers would be wrong, though. Use AdjustForFragmentation() only for margins, and rename it to AdjustMarginsForFragmentation(). The fieldset layout algorithm was using this one for borders/padding, while block and multicol layout called AdjustBorderScrollbarPaddingForFragmentation() in container_builder_. Become more uniform by calling that method for all in SetupFragmentBuilderForFragmentation() (via the base layout algorithm constructor). Since this depends on the initial fragment geometry being set, also do that in the base layout algorithm constructor. Bug: 829028 Change-Id: I6808d023e4e79ab489bdb3a48e3c6c47cf9db6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287313 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#786791}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2287313
branch
from
bd67f1e
to
a453761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we reached the end of a block in an earlier fragmentainer, but
there's overflowing content, we'll revisit this block in subsequent
fragmentainers as long as child content needs it. Repeating the
block-end margins in these fragmentainers would be wrong, though.
Use AdjustForFragmentation() only for margins, and rename it to
AdjustMarginsForFragmentation().
The fieldset layout algorithm was using this one for borders/padding,
while block and multicol layout called
AdjustBorderScrollbarPaddingForFragmentation() in container_builder_.
Become more uniform by calling that method for all in
SetupFragmentBuilderForFragmentation() (via the base layout algorithm
constructor). Since this depends on the initial fragment geometry being
set, also do that in the base layout algorithm constructor.
Bug: 829028
Change-Id: I6808d023e4e79ab489bdb3a48e3c6c47cf9db6c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287313
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786791}