Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline: 2.7 -> 2.8.1 #92712

Merged
merged 1 commit into from Jul 8, 2020
Merged

powerline: 2.7 -> 2.8.1 #92712

merged 1 commit into from Jul 8, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Jul 8, 2020

Motivation for this change

New upstream version. I've also added all optional dependencies, except for bzr, which we no longer have in nixpkgs. The replacement, breezy, does not seem to be supported by powerline.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

should we also export a top-level powerline attr?

@gebner
Copy link
Member Author

gebner commented Jul 8, 2020

The top-level attribute seems like a good idea. I'll add it.

jonringer
jonringer approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92712 1

2 packages built:
- python37Packages.powerline
- python38Packages.powerline

@jonringer jonringer merged commit 8447475 into NixOS:master Jul 8, 2020
@justin-gerhardt justin-gerhardt mentioned this pull request Jul 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @jonringer