[lint] Allow multiple --ignore-glob in wpt lint
#24520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
approved these changes
Jul 9, 2020
Hexcles
added a commit
that referenced
this pull request
Jul 10, 2020
This was introduced in #24520 accidentally.
Merged
Hexcles
added a commit
that referenced
this pull request
Jul 10, 2020
* [lint] Fix a type annotation This was introduced in #24520 accidentally. * Skip quic in pytest and coverage quic/ contains Python 3-only code that leads to warnings when running `pytest --cov` in Python 2. * Mark a test as expected to fail on Windows+py3 See #24561 for details. * Drive-by: change docker-worker schema URL
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jul 14, 2020
This brings in a critical change to allow us skipping multiple patterns in `wpt lint`: web-platform-tests/wpt#24520 Bug: 1103374 Change-Id: I8f8fcf85ce3930e94d3f3453dfcc77aedd0e883f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297680 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#788183}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This brings in a critical change to allow us skipping multiple patterns in `wpt lint`: web-platform-tests/wpt#24520 Bug: 1103374 Change-Id: I8f8fcf85ce3930e94d3f3453dfcc77aedd0e883f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297680 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#788183} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: adff881192be92a1e6624d89f89e4fd67fcf6125
ns-rsilva
pushed a commit
to ns-rsilva/chromium
that referenced
this pull request
Apr 25, 2024
This brings in a critical change to allow us skipping multiple patterns in `wpt lint`: web-platform-tests/wpt#24520 Bug: 1103374 Change-Id: I8f8fcf85ce3930e94d3f3453dfcc77aedd0e883f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297680 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#788183} Former-commit-id: adff881192be92a1e6624d89f89e4fd67fcf6125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by https://crbug.com/1103374 to add additional globs in Chromium