Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CiscoIPPhone: init at 0.05 #92758

Merged
merged 1 commit into from Jul 9, 2020
Merged

perlPackages.CiscoIPPhone: init at 0.05 #92758

merged 1 commit into from Jul 9, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from stigtsp July 9, 2020 00:59
@aanderse
Copy link
Member Author

aanderse commented Jul 9, 2020 •
edited

@GrahamcOfBorg build perlPackages.CiscoIPPhone perldevelPackages.CiscoIPPhone

stigtsp
stigtsp approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did some basic manual testing of the eaxmples (since the module has a very limited test suite).

pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@aanderse aanderse force-pushed the perl-packages/cisco-ipphone branch from 11a14be to 761851b Compare July 9, 2020 10:55
@aanderse aanderse merged commit b1d6b5d into NixOS:master Jul 9, 2020
@aanderse
Copy link
Member Author

aanderse commented Jul 9, 2020

Thanks @stigtsp, much appreciated!

@aanderse aanderse deleted the perl-packages/cisco-ipphone branch July 9, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @stigtsp