New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minecraft-server: add declarative setting for ops.json #92711
Conversation
Any update here? |
Hm is this backwards compatible? Because before this PR people would use |
Current |
Yeah that would be nice. One thought I've had for a while is to be able to toggle options between being static and dynamic. The static implementation of it would be declarative using the NixOS config (which is declarative, but also slow to change), and the dynamic implementation would allow runtime configuration. Changing an option between static and dynamic is still a bit hard though. |
Wouldn't that be the same as having a |
It would be a {
services.minecraft = {
whitelist.declarative = true;
whitelist.value = [ ... ];
ops.declarative = false;
# ops is taken from /var/lib/minecraft/ops.json
};
} And that without having to declare all the |
description = "Level of the OP permissions of the OP user."; | ||
}; | ||
}; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops.json
also features a "bypassesPlayerLimit": bool
option that I suggest adding here (defaulting to false
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Busying now, probably would apply the change a few days later.
A competing PR has been opened a few months ago: #107308 |
Okay how about this: Only when |
That sounds good to me @infinisil. I would like the same to be true for other options. Personally I would use immutable ops and properties, but a mutable whitelist managed in-game by the ops. |
I marked this as stale due to inactivity. → More info |
Motivation for this change
ops.json
is used to manage server operators in Minecraft. Why don't we manage it declaratively!Things done
Manage
ops.json
declaratively; applynixfmt
(I think the formatting is generally fine here).sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)