Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 3.3.1 -> 3.8.0 #92691

Merged
merged 1 commit into from Jul 26, 2020
Merged

kustomize: 3.3.1 -> 3.8.0 #92691

merged 1 commit into from Jul 26, 2020

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Version update

Things done

tree removed, since doesn't look necessary
buildDate flag removed. If unset, the default date is 1/1/1970, which is
common practice when building nix packages

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jlesquembre
kustomize: 3.3.1 -> 3.8.0
e9d928a 
tree removed, since doesn't look necessary
buildDate flag removed. If unset, the default date is 1/1/1970, which is
common practice when building nix packages
vdemeester
vdemeester approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

zaninime
zaninime approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@zaninime zaninime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't kustomize now officially part of kubectl as well? Do we need to keep a separate package for it? Otherwise LGTM.

@jlesquembre
Copy link
Member Author

yes, kustomize is part of kubectl, but it doesn't get any updates. On latest kubectl, kustomize is still on version 2. As long as nothing changes, it makes sense to me to keep a separate package

@zaninime
Copy link
Contributor

@marsam could this be merged too? thanks.

@marsam marsam merged commit 9fc4678 into NixOS:master Jul 26, 2020
@jlesquembre jlesquembre deleted the kustomize-3.8.0 branch April 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@zaninime zaninime zaninime approved these changes

@periklis periklis Awaiting requested review from periklis

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jlesquembre @zaninime @vdemeester @marsam