Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melpaBuild: Update package-build #95865

Closed
wants to merge 2 commits into from
Closed

melpaBuild: Update package-build #95865

wants to merge 2 commits into from

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Aug 20, 2020 •
edited

Motivation for this change

The current version of package-build used to build MELPA packages is from 2018, and there have been a number of changes since then. I think it's better to update it, and this can potentially resolve various issues related to the Emacs infrastructure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 95865 run on x86_64-linux 1

1 package built:
  • cask

@akirak
Copy link
Contributor Author

akirak commented Dec 30, 2020

I don't know how to test this change, but I built Emacs using the following expression, and result/bin/emacs successfully started and the package was available:

let
  pkgs = import ./default.nix {
    system = builtins.currentSystem;
  };
in
pkgs.emacsWithPackages (epkgs: [
  epkgs.org-ql
])

@stale
Copy link

stale bot commented Jun 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2021
@adisbladis
Copy link
Member

Obsoleted by #129458

@adisbladis adisbladis closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: emacs 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akirak @SuperSandro2000 @adisbladis