Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base time unit from ps to fs #217

Closed
azonenberg opened this issue Aug 4, 2020 · 1 comment
Closed

Change base time unit from ps to fs #217

azonenberg opened this issue Aug 4, 2020 · 1 comment
Labels
api API improvements cleanup Removing cruft

Comments

@azonenberg
Copy link
Collaborator

This will be a major, wide-reaching refactor across huge amounts of the code, so should not be taken lightly.

Range should still be adequate: 2^64 fs is around five hours, which should be more than enough for any single scope acquisition.

But for higher speed serial data, it's possible that we're going to start seeing problems due to roundoff as we convert things to ps. The CDR PLL is already using floating point timestamps to work around this.

Discuss.
@azonenberg azonenberg added api API improvements cleanup Removing cruft labels Aug 4, 2020
@azonenberg azonenberg changed the title Consider changing base time unit from ps to fs Change base time unit from ps to fs Nov 28, 2020
@azonenberg
Copy link
Collaborator Author

Required to support 80 Gsps scopes.

azonenberg added a commit that referenced this issue Nov 28, 2020
@azonenberg
scopehal: Refactored all drivers, triggers, and Unit class to use fem…
e85f1a9 
…toseconds instead of picoseconds as base time unit. See #217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API improvements cleanup Removing cruft
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azonenberg