Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapNeovim: fix darwin build #94643

Merged
merged 1 commit into from Aug 4, 2020
Merged

wrapNeovim: fix darwin build #94643

merged 1 commit into from Aug 4, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Address comment in #88110 (comment) .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 4, 2020
@doronbehar doronbehar mentioned this pull request Aug 4, 2020
Merged
10 tasks
@doronbehar
Copy link
Contributor Author

cc @cideM

@doronbehar
Copy link
Contributor Author

@GrahamcOfBorg build neovim

@zowoq zowoq linked an issue Aug 4, 2020 that may be closed by this pull request
neovim wrapper fails to build on macOS #94633
Closed
danieldk
danieldk approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to resolve the build error on Darwin.

@danieldk danieldk merged commit a7aae2e into NixOS:master Aug 4, 2020
@cideM
Copy link
Contributor

cideM commented Aug 4, 2020

That was lightning fast, thank you (meaning "wow")

@doronbehar doronbehar deleted the wrapNeovim branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

neovim wrapper fails to build on macOS
3 participants
@doronbehar @cideM @danieldk