Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itk4: 4.13.2 -> 4.13.3 #94631

Merged
merged 1 commit into from Aug 16, 2020
Merged

itk4: 4.13.2 -> 4.13.3 #94631

merged 1 commit into from Aug 16, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Aug 4, 2020 •
edited

Motivation for this change
  • maintenance release, in particular adds compatibility with newer GCCs
  • unbreak Darwin build
Things done
  • bumped gcc8Stdenv -> stdenv in this package and its reverse deps
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from viric August 4, 2020 00:41
@bcdarwin bcdarwin force-pushed the itk4-update branch 2 times, most recently from a827051 to b05d4e3 Compare August 4, 2020 02:17
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/253

@bcdarwin bcdarwin requested a review from alyssais August 16, 2020 17:55
@alyssais alyssais merged commit 9b589c7 into NixOS:master Aug 16, 2020
@bcdarwin bcdarwin deleted the itk4-update branch August 16, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @nixos-discourse @alyssais