Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagemagick-support to exwm's emacs #94648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moritzschaefer
Copy link
Contributor

@moritzschaefer moritzschaefer commented Aug 4, 2020

Motivation for this change

There is an open discussion about how to add ImageMagick-support to emacs. Unfortunately, there is no solution to add ImageMagick-support to emacs when using EXWM. This PR is an intent to fix this.

I added pkgs.imagemagick to the cfg.extraPackages attribute in my config (though I'm not sure if it's really necessary).

This is just a proposal, and I see that, for now, the code is not very flexible. I'm happy for suggestions on how to make adding packages to exwm's emacs more flexible, in case it's necessary.

Closes #70631

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Closes #70631

@moritzschaefer
Copy link
Contributor Author

Is there a reason not to merge this @SuperSandro2000?

@SuperSandro2000
Copy link
Member

Is there a reason not to merge this @SuperSandro2000?

I never used emac.

@stale
Copy link

stale bot commented Aug 1, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emacs: providing ImageMagick support
2 participants