buildGoModule: change doCheck default to true #94632
Conversation
| @@ -13,6 +13,8 @@ buildGoModule rec { | |||
|
|
|||
| vendorSha256 = "05vnysr5r3hbayss1pyifgp989kjw81h95iack8ady62k6ys5njl"; | |||
|
|
|||
| doCheck = false; | |||
There was a problem hiding this comment.
By checking them and making PRs but not all at once. I wanted this to be a no-rebuild PR so it's an easy merge.
I wanted to flip the default now while it isn't to much trouble and so it applies to buildGoPackage -> buildGoModule changes and new packages.
There was a problem hiding this comment.
Have you checked what the success rate of checks for go packages in general is? I am asking because this will also affect out-of-tree packages.
There was a problem hiding this comment.
Currently it's barely used and doesn't get mentioned during PR reviews.
Making this opt out (same as buildRustPackage) will be better long term.
I am asking because this will also affect out-of-tree packages.
Yeah, I think now is a good time to do this with vendorSha changes also affecting those packages.
|
@zowoq I think you got enough approvals. Please rebase and make sure no new Go packages were added that will be affected by this change and merge. |
|
There were seven additional packages using |
They run just fine. Seems to be a leftover from NixOS#94632 (cea7cd9), which changed the default of `doCheck` from `false` to `true`
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)